Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename logs as log_entries, move movels to app/Models #291

Merged
merged 11 commits into from
Oct 27, 2020
Merged

Conversation

supertassu
Copy link
Collaborator

@supertassu supertassu commented Sep 12, 2020

This will have merge conflicts with everything!

closes #139
see #103 (especially #103 (comment)) & #285 for more details

Includes:

  • Move all models to app/Models per Laravel 8 norms
  • Rename logs to log_entries due to conflict with a Laravel class
  • Rename columns in log_entries:
    • referenceobject -> model_id
    • objecttype -> model_type
    • user -> user_id
  • Change all uses to above columns to use new names
  • Change model_type to use current class names instead of old names and previous class names

@supertassu supertassu self-assigned this Sep 12, 2020
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Rename logs as log_entries, move movels to app/Models

Powered by Pull Assistant. Last update bc72cf9 ... bc72cf9. Read the comment docs.

@supertassu supertassu marked this pull request as ready for review October 26, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make log entry reference type a proper Laravel polymorphic relationship
2 participants