Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commenting #396

Merged
merged 2 commits into from
Dec 12, 2020
Merged

Fix commenting #396

merged 2 commits into from
Dec 12, 2020

Conversation

supertassu
Copy link
Collaborator

closes #394

I'm not exactly sure what the /appeal/respond/{appeal} route is used for, it should be affected by the same bug - but I didn't find any uses of that route outside routes/web.php.

@supertassu supertassu added bug Something isn't working Priority: High labels Dec 12, 2020
@supertassu supertassu self-assigned this Dec 12, 2020
@dqwiki
Copy link
Member

dqwiki commented Dec 12, 2020

@supertassu originally I think it was to separate administrative comments from replies to the user as they were using different systems. I know it underwent a big change when we instituted templates, so I feel it got deprecated there.

Was likely replaced by this:

Route::post('/appeal/template/{appeal}/{template}', 'AppealController@respond')->name('appeal.template.submit');
Route::get('/appeal/custom/{appeal}', 'AppealController@respondCustom')->name('appeal.customresponse');
Route::post('/appeal/custom/{appeal}', 'AppealController@respondCustomSubmit')->name('appeal.customresponse.submit');

Copy link
Member

@dqwiki dqwiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the additional line as there was no adverse affect when I did.

@dqwiki dqwiki merged commit b2d1fb3 into master Dec 12, 2020
@dqwiki dqwiki deleted the fix-commenting branch December 12, 2020 22:04
supertassu added a commit that referenced this pull request Dec 13, 2020
The results haven't actually been used in ages (if ever), so I don't mind just
dropping all data.

per #401 and #396 (comment)

closes #401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add private comments to appeals (was: RealMediaWiki error)
2 participants