-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create working cmake files for examples (version 2) #302
Conversation
Pull reviewers statsStats of the last 120 days for UWOrbital:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarification on -Werror comment
Handling adc and other examples that were merged recently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
low risk so lgtm as long as the examples build correctly. I'll let navtaj approve
Wait for examples check to finish before merge |
All examples built so merging in |
Purpose
Add working cmakelists for example files
This PR replaces Create working cmake files for example files #259 as that one had way too many merge conflicts to deal with.
Notion task: https://www.notion.so/uworbital/6375c5c5dcf1485e8a6c47f18d419ae5?v=72baf90d01f643b09d77418bd3f53b14&p=062e93d0a1b54c608dcdf98fa46a720c&pm=s
New Changes
Examples
build option in top-level directory CMakeLists-Werror
only apply for OBC build (test that it still errors on warnings by adding unused variables)Testing
test_app_rtc/main.c
obc/examples
with new CMakeLists.Outstanding Changes
-Werror
apply to all example builds once all example builds are fixedtest_app_fram_persist
,test_app_rs
has unresolved warnings.test_app_freertos_posix
has unresolved warnings and source file errors.test_app_mpu6050
,test_app_cc1120_spi
has source file errors.test_app_rtc
- location of initLogger is changed so need update from source file.test_app_fram_spi
,test_app_reliance_edge_sd
,test_app_uart_rx
,test_app_uart_tx
,dma_spi_demo
has no errors.