Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create working cmake files for examples (version 2) #302

Merged
merged 14 commits into from
Oct 13, 2024

Conversation

Yarik-Popov
Copy link
Contributor

Purpose

New Changes

  • Added Examples build option in top-level directory CMakeLists
  • Added options in obc/CMakeLists to build specified example in obc/examples
  • Added instructions for how to build an example in README
  • Make -Werror only apply for OBC build (test that it still errors on warnings by adding unused variables)
  • Move and separate tests under comms_link_mgr to examples
  • Delete unused makefiles in examples

Testing

  • Commented out initLogger() function from test_app_rtc/main.c
  • Manually build all the example files from obc/examples with new CMakeLists.

Outstanding Changes

  • Make -Werror apply to all example builds once all example builds are fixed
  • Make obc github workflows independent for each board
  • Fix errors from example source files. Listed here:
  • test_app_fram_persist, test_app_rs has unresolved warnings.
  • test_app_freertos_posix has unresolved warnings and source file errors.
  • test_app_mpu6050, test_app_cc1120_spi has source file errors.
  • test_app_rtc - location of initLogger is changed so need update from source file.
  • test_app_fram_spi, test_app_reliance_edge_sd, test_app_uart_rx, test_app_uart_tx, dma_spi_demo has no errors.

Copy link

Pull reviewers stats

Stats of the last 120 days for UWOrbital:

User Total reviews Time to review Total comments
Yarik-Popov 11 9d 20h 58m 116
kepler452b123 5 9h 15m 32
Navtajh04 4 12h 6m 28
dgobalak 3 7h 41m 15
Gjjjiang 1 35d 1h 57m 1

⚡️ Pull request stats

obc/CMakeLists.txt Show resolved Hide resolved
.github/workflows/obc_examples.yml Show resolved Hide resolved
cmake/toolchain_arm_none_eabi.cmake Show resolved Hide resolved
Copy link
Contributor Author

@Yarik-Popov Yarik-Popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarification on -Werror comment

obc/CMakeLists.txt Outdated Show resolved Hide resolved
@Yarik-Popov
Copy link
Contributor Author

Handling adc and other examples that were merged recently

Copy link
Member

@dgobalak dgobalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low risk so lgtm as long as the examples build correctly. I'll let navtaj approve

@Navtajh04
Copy link
Contributor

Wait for examples check to finish before merge

@Yarik-Popov
Copy link
Contributor Author

All examples built so merging in

@Yarik-Popov Yarik-Popov merged commit 3133e4d into main Oct 13, 2024
44 of 45 checks passed
@Yarik-Popov Yarik-Popov deleted the yarik/new-cmake-examples branch October 13, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants