Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Guide for from_file function #1047

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

rajeeja
Copy link
Contributor

@rajeeja rajeeja commented Oct 29, 2024

Users guide for using from_file GRID function #946

@rajeeja rajeeja self-assigned this Oct 29, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rajeeja rajeeja mentioned this pull request Oct 29, 2024
@philipc2
Copy link
Member

Do you have any files from climate models or similar that you should showcase in this notebook? I'm not sure if showcasing the multipoly.shp is relevant to our users, as it isn't a proper grid.

@rajeeja
Copy link
Contributor Author

rajeeja commented Oct 29, 2024

Do you have any files from climate models or similar that you should showcase in this notebook? I'm not sure if showcasing the multipoly.shp is relevant to our users, as it isn't a proper grid.

yes, this PR is work in progress. I'll make it a draft.

@rajeeja rajeeja changed the title User Guide for from_file function DRAFT: User Guide for from_file function Oct 29, 2024
rajeeja and others added 22 commits October 31, 2024 15:14
o Remove the multipoly example, the old bug still exists, but that can be handled in issue #1048
@aaronzedwick aaronzedwick marked this pull request as draft November 11, 2024 16:08
@aaronzedwick
Copy link
Member

@philipc2 Do you know why the docs are different than the actual notebook? You can compare on reviewNB, the notebook is different on the docs site.

@rajeeja
Copy link
Contributor Author

rajeeja commented Nov 12, 2024

@philipc2 Do you know why the docs are different than the actual notebook? You can compare on reviewNB, the notebook is different on the docs site.

Can you give the two links?

There's only a python version change here, right? :
docs/user-guide/from-points.ipynb

@aaronzedwick
Copy link
Member

@philipc2 Do you know why the docs are different than the actual notebook? You can compare on reviewNB, the notebook is different on the docs site.

Can you give the two links?

There's only a python version change here, right? : docs/user-guide/from-points.ipynb

That isn't the notebook I am talking about, I am looking at the from_file notebook. The bug is fixed now though.

@rajeeja rajeeja changed the title DRAFT: User Guide for from_file function User Guide for from_file function Nov 12, 2024
@rajeeja rajeeja marked this pull request as ready for review November 13, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants