-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jamtis changes #6
Conversation
* nominal address tag protection for LWs (extra address key) * flexible view tags * churning and pocketchange protection for LWs (auxiliary enote records) PR implementing changes is here: UkoeHB/monero#26
…or descriptors, and super-scripts are mainly for variations of the same underlying key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started the review, see commits for changes. Stopped when I encountered a math issue.
I need to update the Janus attack section, I think I edited locally and forgot to push the changes Edit: done |
8db1923
to
5cac97f
Compare
Implementation note: a selfsend enote with a primary view tag must be randomly positioned in the list of selfsends. |
Summary of changes as I understand them:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, overall I am actually happy with the privacy improvements. This is a clean set of solutions to the targeted problems.
The costs are rather painful: 1 more address key, complexity for the view tag bit fiddling, 2x data on remote-scanner client, way slower to scan on the remote-scanner client (probably 100x).
You should go through the changes I made before I merge this. Also, what name and email address do you want to put in the author section?
I really like the modifications you made to it. There was a lot of cleaning to do it seems ;) I just pushed 2 commits which I think make the upfront description flow a little cleaner, and expand on
I'm glad you're happy with the privacy improvements. At the risk of being unmodest, these changes are definitely opinionated, but I really like tradeoffs, and these Jamtis changes will probably be good enough for me to switch to a light wallet as my daily wallet (even though I do value privacy strongly). I agree, the costs are pretty painful, but hopefully the computational performance differences these changes bring will be more forgiving in real-world systems than they are on paper (real-world processors having multiple compute threads and mainly being bottle-necked by network I/O). Another personal opinion, but if there comes a time that a majority of light wallet users can not handle a small fraction of the on-chain enotes, that means that full wallets and nodes loads are likely struggling much worse, and there is scaling work to be done elsewhere. Thanks for going through all the work to review! |
Did some slight cleanup on your last commits.
|
|
PR implementing changes is here: UkoeHB/monero#26