Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Japanese localization #19438

Closed
h1data opened this issue Jul 27, 2024 · 14 comments · Fixed by #19473
Closed

Improve Japanese localization #19438

h1data opened this issue Jul 27, 2024 · 14 comments · Fixed by #19473
Labels
Type: Bug The code does not produce the intended behavior.

Comments

@h1data
Copy link
Contributor

h1data commented Jul 27, 2024

Cura Version

5.7.2

Operating System

not specific

Printer

not specific

Reproduction steps

Hello, I've recently considered improving Cura's Japanese localization.
(and discovered issue #19401)

Based on the Translating Cura wiki page, I have been preparing PR for 5.7.2, but other translation words were added in the 5.8 branch.
Also, it is said your team uses Lokalise translation service in #18614.

How do I join the translation work?

Actual results

There are problems in Japanese localization.

1. Mistranslations

Example

msgctxt "@action:inmenu"
msgid "Toggle Full Screen"
msgstr "留め金 フルスクリーン"

"留め金" might be from "Toggle", but rather a metal hook that holds doors/gates.

It seems due to bad machine translation and not checked in the actual program.

(it would be "全画面表示切替")

That is just an example and there are other mistranslations.

2. Inconsistent terms

The common terms in the program should be consistent but there are some inconsistent translations.

For example, "material" is a common term but there are different translations; "フィラメント" (filament), "材料" (translated straightly), or "マテリアル" (katakana for "material").

3. misuses of & operators for the menu shortcut keys.

&x indicates the shortcut key x in menus, however, there are misuses for & operators.

Example

msgctxt "@title:menu menubar:toplevel"
msgid "&File"
msgstr "&ファイル"

&フ is not recognized as a shortcut key, so just displayed as "&ファイル".

In most Japanese software, the menu shortcut key is displayed in parenthesis like "ファイル(F)", thus it would be "ファイル(&F)".

4. Multiline is not displayed properly

Example

msgctxt "@text"
msgid ""
"- Add material profiles and plug-ins from the Marketplace\n"
"- Back-up and sync your material profiles and plug-ins\n"
"- Share ideas and get help from 48,000+ users in the UltiMaker community"
msgstr "- マーケットプレースから材料プロファイルとプラグインを追加- 材料プロファイルとプラグインのバックアップと同期- UltiMakerコミュニティで48,000人以上のユーザーとアイデアを共有してアドバイスをもらう"

Those lines are not broken into lines. (see additional information)

There should be \n at each end and split into lines like below.

msgctxt "@text"
msgid ""
"- Add material profiles and plug-ins from the Marketplace\n"
"- Back-up and sync your material profiles and plug-ins\n"
"- Share ideas and get help from 48,000+ users in the UltiMaker community"
msgstr "- マーケットプレースから材料プロファイルとプラグインを追加\n"
"- 材料プロファイルとプラグインのバックアップと同期\n"
"- UltiMakerコミュニティで48,000人以上のユーザーとアイデアを共有してアドバイスをもらう"

Expected results

see actual results

Add your .zip and screenshots here ⬇️

example for 4. Multiline is not displayed properly
bad-multiline

@h1data h1data added Status: Triage This ticket requires input from someone of the Cura team Type: Bug The code does not produce the intended behavior. labels Jul 27, 2024
@HellAholic
Copy link
Contributor

Hey @h1data ,
We have a list of community contributors for the translations, after the release branch is made and before the Beta release, we send an email to our contributors. There is a window of time (1-3 weeks) in which you can make a PR for the translations for the next release.
Outside of that window, for corrections on the text already in place, you can make a PR against the main branch which will be included in the future releases.
For languages that we don't have a contributor, we rely on translation services like Lokalise.

If you would like to participate as a community contributor for the Japanese localization we can set things up so you would also receive an email and the notification.
Would that be something you're interested in?

@HellAholic HellAholic added Status: Needs Info Needs more information before action can be taken. and removed Status: Triage This ticket requires input from someone of the Cura team labels Jul 27, 2024
@h1data
Copy link
Contributor Author

h1data commented Jul 27, 2024

Thanks for the invitation!
I would like to receive emails for beta branches.
Please tell me the email address to send it, or DM me on X (@h1data).

I will make a PR to the main branch for future releases.

@github-actions github-actions bot removed the Status: Needs Info Needs more information before action can be taken. label Jul 27, 2024
@h1data
Copy link
Contributor Author

h1data commented Oct 12, 2024

@wawanbreton Thanks for merging the PR!

I found untranslated lines in the 5.9 branch
and translation suggestions by a Japanese user.
https://note.com/y_labo/n/nee490a276494
At this moment, is 5.9 the branch to make PR?

Btw, please check the PR in the Uranium repository too.

@wawanbreton
Copy link
Contributor

I found untranslated lines in the 5.9 branch and translation suggestions by a Japanese user. https://note.com/y_labo/n/nee490a276494 At this moment, is 5.9 the branch to make PR?

Right now, I have sent the labels to our translation service, and they are ready to be integrated. This means thah quite soon, the 5.9 branch will be updated and there should be no more missing translations. No need to do the translation then, but you can still make a review on the new labels.

Btw, please check the PR in the Uranium repository too.

Oh sorry I forgot that. I hope that will not conflict with the fresh new translations 😬

I also see on the discussion that you were willing to register for regular Japanese translation, is that still the case ? We currently do it via a professional service, but having them done by a contributor has many advantages.

@h1data
Copy link
Contributor Author

h1data commented Oct 15, 2024

Yes, I'm willing to contribute to the product!
However, to guarantee the quality, it is better to have others double-check as mentioned in #19473.
I will consider the translation process after the translation update in 5.9.
(when should I translate, if the service is necessary, etc)

@wawanbreton
Copy link
Contributor

Yes, I'm willing to contribute to the product!

Cool, let's go for it 🙂 what is the easiest way I can get your email ?

when should I translate

When we do the feature freeze for a new release, we create the feature branch then immediatly update the translations files. Then we send the new labels to our translations service, and for contributed languages we send an email to the translators. That usually lets a few weeks for them to make a PR with the updated files. On average it is about 40 new labels, every ~3 month.

if the service is necessary

We usually trust the contributors to do it correctly 🙂 although professional translators may have more experience, they usually miss the context and the usual wording, especially in 3D printing which is very technical. However if you have some doubts, just tell us and we will have the translations double-checked.

@h1data
Copy link
Contributor Author

h1data commented Oct 16, 2024

I have a contact form instead of a public address.
Could you contact me via the URL below? I will reply to the input address.
https://h1data.github.io/contact.html
Or DM @h1data on X if you have an account.

@h1data
Copy link
Contributor Author

h1data commented Oct 28, 2024

@wawanbreton
Thanks again for receiving and merging the updates!
We have accomplished to solve those issues above for now.
I'll close this issue, however, there is still a concern
about applying our changes to the translation service.
I would like to discuss it in future updates.

@h1data h1data closed this as completed Oct 28, 2024
@wawanbreton
Copy link
Contributor

I would like to discuss it in future updates.

Well, for future updates I will not send the Japanese translation to Lokalize, only to you, so there should be no confusion. In case you are too busy, we can still send them to Lokalize later because they are usually very fast. Did you have something different in mind ?

@h1data
Copy link
Contributor Author

h1data commented Oct 28, 2024

I think it is the straight way, too.
I can translate for usual updates in at least a few days.
Also, I would like to find others who can translate or proofread for quality.

@wawanbreton
Copy link
Contributor

Also, I would like to find others who can translate or proofread for quality.

We usually don't do that, and it would be extremely complex to do it for every language 😅 The best I can think of is for you to find people around you than know a bit of 3D printing and have them test the software. I can occasionally ask for people in the company to make a specific review, that should be doable. If that is what you want, send me an email with some details about the scope of the review.

@bgpat
Copy link

bgpat commented Oct 28, 2024

Also, I would like to find others who can translate or proofread for quality.

I can review Japanese translations. Feel free to contact me if needed.

@h1data
Copy link
Contributor Author

h1data commented Oct 28, 2024

@bgpat
Thank you for reaching us!
I would like to have the translations reviewed.
I'll send details on DM (X).

@wawanbreton
No person with 3D printers around me, but Tanaka-san offers help!
I'll be glad if he helps to check the translations.

@wawanbreton
Copy link
Contributor

Awesome, thanks @bgpat for the help 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The code does not produce the intended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants