Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile for Ender3 v2 #10216

Closed
wants to merge 2 commits into from
Closed

Add profile for Ender3 v2 #10216

wants to merge 2 commits into from

Conversation

pcartwright81
Copy link

Add profile for Ender3 v2

@konskarm
Copy link
Contributor

konskarm commented Aug 9, 2021

I notice that the only difference between the Ender3 and the Ender3v2 files is the size of the printer. Keep in mind that the Ender3 used to also be 220x220x250mm but it was changed in commit 726561b after the discussion in #6267.

Is there a change the same situation will arise in the Ender3v2? Because if that's the case, I think the Ender3v2 users can be covered by the Ender3 printer profile so that we don't have to have two different printer profiles that are exactly the same.

@nallath nallath added the Status: Needs Info Needs more information before action can be taken. label Aug 12, 2021
@emarforio
Copy link

I for one would appreciate to have the "duplicate" config. I am very new to 3D-printing and just bought my first printer, an Ender 3 V2, and were a bit confused and put off by not finding the exact model at first. So even if the config is the same it is nice to show newbies like me that their device is supported out of the box.

@pcartwright81
Copy link
Author

I for one would appreciate to have the "duplicate" config. I am very new to 3D-printing and just bought my first printer, an Ender 3 V2, and were a bit confused and put off by not finding the exact model at first. So even if the config is the same it is nice to show newbies like me that their device is supported out of the box.

Agree. It was a little confusing at first why I had to manually copy the profile and set the dimensions. Didn't know how to respond to the pull request comment. Was hoping someone would say whether or not the dimensions needed to be updated or not.

@mdehaas
Copy link

mdehaas commented Aug 19, 2021

I do not agree that because users are confused (and not willing to investigate further) there is a need to create duplicate profiles. This causes changes to the profile (and possibly code) need to be applied on multiple files. This will eventually lead to drift (forgotten or orphaned profiles). The solution in my opinion should be that if a profile applies to multiple vendors/series/models/editions there should be a possibility to add more than one of the above to the profile.
This however will lead to a lengthy list in the configuration dialog so a new 'user journey' has to be modelled around that.

@Ghostkeeper
Copy link
Collaborator

For one, it would be nicer to inherit from the Ender 3 (v1) profile if it's just the size that is different, and then override just that size. That way if other things change in the Ender 3 profile, like an improved start g-code, it would also change for the v2.

The profiles are already shared among all Creality printers anyway, so it wouldn't lead to duplication there, or outdatedness.

Another possibility instead of this would be to add a machine action that allows the user to choose which edition of the printer they have. The Ultimaker Original does something like that, where you get another screen after adding the printer where the user can select whether they have the heated bed installed in their printer or not.

@mattpker
Copy link

mattpker commented Nov 3, 2021

To solve the issue of confusion, the profile for "Ender-3" could be renamed to "Ender-3 (v1/v2)".

@Medduus
Copy link

Medduus commented May 9, 2022

in the endeer slicer that is based on cura u can get the profiles for the v2

@amweiss
Copy link
Contributor

amweiss commented Jun 4, 2022

I notice that the only difference between the Ender3 and the Ender3v2 files is the size of the printer. Keep in mind that the Ender3 used to also be 220x220x250mm but it was changed in commit 726561b after the discussion in #6267.

Is there a change the same situation will arise in the Ender3v2? Because if that's the case, I think the Ender3v2 users can be covered by the Ender3 printer profile so that we don't have to have two different printer profiles that are exactly the same.

This is correct, the bed size between the Ender 3 and Ender 3v2 is the same. It's actually 235x235x250 but only prints to 220x220x250. I would agree with the above suggestion to just rename the profile to include "(v1/v2)"

#12442

@digitalfrost
Copy link
Contributor

Can be closed since Rename Ender-3 profile to include v2 #12442 has been merged.

@nallath nallath closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Info Needs more information before action can be taken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants