Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AddCuraSettings.py #15854

Closed
wants to merge 6 commits into from
Closed

Create AddCuraSettings.py #15854

wants to merge 6 commits into from

Conversation

GregValiant
Copy link
Collaborator

@GregValiant GregValiant commented Jun 22, 2023

A new post processor that adds the Cura settings to the end of a gcode file. #15846 Refer to request #5962

This fixes... OR This improves... -->

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [ X] Tested with 4.x and 5.x versions

Test Configuration:

  • Operating System: Win10 Home, Ender 3 Pro with Marlin firmware

Checklist:

  • [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [ X] I have read the Contribution guide
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [X ] I have uploaded any files required to test this change

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Jun 22, 2023
@GregValiant
Copy link
Collaborator Author

@fieldOfView since I cribbed all of this from your "replacement patterns" page I thought you would be a good choice to review it.

@GregValiant GregValiant requested review from casperlamboo and removed request for fieldOfView September 12, 2023 23:55
@GregValiant GregValiant mentioned this pull request Sep 15, 2023
Made some additions

Update AddCuraSettings.py

Update AddCuraSettings.py

Remove code that added the PP name to the gcode.

Create AddCuraSettings.py

A new post processor that adds the Cura settings to the end of a gcode file.

Update AddCuraSettings.py

Added more settings for Adaptive Layers.

Update AddCuraSettings.py

Add RepRap fan scale setting
Updated some extruder call outs.
Some code changes for birm and raft settings.
Added 'Keep Models Apart' and 'Drop Models to Build Plate' to the list of settings.
@GregValiant GregValiant marked this pull request as draft November 29, 2023 16:32
@GregValiant GregValiant marked this pull request as ready for review December 17, 2023 22:49
Changed some formatting throughout.
Added actual print speeds from the gcode.
Fixed a typo line 540

Update AddCuraSettings.py

Adjusted some formatting.

Update AddCuraSettings.py

Added a message
@GregValiant GregValiant deleted the AddCuraSettings branch December 19, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant