Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-11146 limit the bloat in the new AppImage #16943

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jellespijker
Copy link
Member

@jellespijker jellespijker commented Oct 11, 2023

Description

The AppDir which we package should already contain the lib we explicitly installed with the AppImage builder. These are after all collected by pyinstaller.

Size is now 268 mb (from 342 mb)

This could also be a solution for:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

Test Configuration:

  • Operating System: Linux Ubuntu 22.04 (GH runner image)

Checklist:

Could also be a solution for:
- #16932
- #16935

Fixes CURA-11146
Fixes #16931
@jellespijker jellespijker changed the base branch from main to 5.5 October 11, 2023 12:25
@nallath nallath merged commit 6f82397 into 5.5 Oct 11, 2023
12 checks passed
@jellespijker jellespijker deleted the CURA-11146_badonka_donk_donk branch December 11, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants