CURA 11132 fix missing icon crash #17080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update removes various icon-theme exclusions from the AppImage build configuration and includes specific hicolor icon files. It also adds new environment variables and path mappings for handling user data more efficiently within the AppImage. This aims to optimize the packing process and improve the resultant AppImage's compatibility and performance. Contributes to CURA-11132
The changes include adding several packages to the list of dependencies for the AppImage-builder, such as libgtk, librsvg2, imagemagick and icon themes. Furthermore, adjustments were made to the runtime environment variables (GDK_PIXBUF_MODULEDIR and GDK_PIXBUF_MODULE_FILE). Excluded file paths were also updated to exclude unnecessary documentation files. Contributes to CURA-11132
casperlamboo
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that all relevant icons and pix-buf libs are packaged. Tested in on Manjaro, Mint 20.4, Debian and Ubuntu
Type of change
How Has This Been Tested?
By running this build on various systems: UltiMaker-Cura-5.6.0-alpha+cura_11132_dd2a80-linux-X64-AppImage
Test Configuration:
Checklist: