Cura 11777 yeet sketch to makerbot #19029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the Makerbot Sketch 3D printer. This includes setting specific configuration parameters, defining a new machine definition and relevant build platform mesh. Material compatibility restrictions are also outlined to adhere with the capabilities of the printer. CURA-11777
This commit introduces the ability to export files in the Makerbot Sketch format.Now the file can be saved as in a gcode format as well.
The file format 'application/x-makerbotsketch' has been updated to 'application/x-makerbot-sketch' across all instances in the code base. In addition, the 'Sketch' option for gcode flavor has been removed from all printer selection menus in different sections of the code. This should be added again once the code is implemented in gcode for this flavor. Also, change flavor in ultimaker_sketch.def.json file CURA-11777
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
casperlamboo
reviewed
May 7, 2024
casperlamboo
reviewed
May 7, 2024
The MakerbotWriter.py file has been adjusted to handle "application/x-makerbot-sketch" files without providing bounding box values. Instead of using the node name for model_counts, it now uses the count of nodes under the name "instance0".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment the Method Sketch printer(not sketch large) is added in Cura in this branch and corresponding changes are done to add the abstract printer from the cloud as well. Makerbot plugin is extended to add the "print.gcode" file instead of "print.jsontoolpath" for the mimetype : application/x-makerbot-sketch
The flavor for Griffin works with the Sketch printers.