Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-475 pla method #19294

Merged
merged 22 commits into from
Jul 2, 2024
Merged

PP-475 pla method #19294

merged 22 commits into from
Jul 2, 2024

Conversation

alanbjorklund
Copy link
Contributor

Description

Newly added settings:

PLA Self support
PLA with PVA support
tested these settings for default & solid intents on Method, Method X & Method XL

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Printer definition file(s)
  • Translations

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Operating System:

Checklist:

github-actions[bot]
github-actions bot requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/extruders/ultimaker_method_extruder_left.def.json Show resolved Hide resolved
resources/extruders/ultimaker_method_extruder_right.def.json Show resolved Hide resolved
github-actions[bot]
github-actions bot requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

resources/intent/ultimaker_methodxl/um_methodxl_1a_um-pla-175_0.2mm_solid.inst.cfg Outdated Show resolved Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_1c_um-pla-175_0.2mm_solid.inst.cfg Outdated Show resolved Hide resolved
resources/intent/ultimaker_methodxl/um_methodxl_labs_um-pla-175_0.2mm_solid.inst.cfg Outdated Show resolved Hide resolved
resources/quality/ultimaker_methodx/um_methodx_2a_um-pva-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodx/um_methodx_2a_um-pva-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_2a_um-pva-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_2a_um-pva-175_0.2mm.inst.cfg Show resolved Hide resolved
github-actions[bot]
github-actions bot requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method.def.json Show resolved Hide resolved
resources/definitions/ultimaker_method.def.json Show resolved Hide resolved
resources/quality/ultimaker_method/um_method_2a_um-pva-175_0.2mm.inst.cfg Outdated Show resolved Hide resolved
resources/quality/ultimaker_methodx/um_methodx_2a_um-pva-175_0.2mm.inst.cfg Outdated Show resolved Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_2a_um-pva-175_0.2mm.inst.cfg Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

resources/definitions/ultimaker_methodx.def.json Show resolved Hide resolved
resources/definitions/ultimaker_methodx.def.json Show resolved Hide resolved
resources/extruders/ultimaker_method_extruder_left.def.json Show resolved Hide resolved
resources/extruders/ultimaker_method_extruder_right.def.json Show resolved Hide resolved
resources/quality/ultimaker_method/um_method_1c_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_method/um_method_1c_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_method/um_method_labs_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_method/um_method_labs_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodx/um_methodx_1c_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodx/um_methodx_1c_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
github-actions[bot]
github-actions bot requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodx/um_methodx_labs_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_1c_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_1c_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_labs_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
resources/quality/ultimaker_methodxl/um_methodxl_labs_um-nylon12-cf-175_0.2mm.inst.cfg Show resolved Hide resolved
@pkuiper-ultimaker
Removed PLA filter from Method X and Method XL.
0d97717 
Changed setting support_infill_density_multiplier_layer_0 to support_infill_density_multiplier_initial_layer.
Added Tough PLA to the MaterialOutputModel.py so it is recognised by Cura.

PP-475
github-actions[bot]
github-actions bot requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Show resolved Hide resolved
resources/definitions/ultimaker_methodx.def.json Show resolved Hide resolved
resources/definitions/ultimaker_methodx.def.json Show resolved Hide resolved
resources/extruders/ultimaker_method_extruder_left.def.json Show resolved Hide resolved
resources/extruders/ultimaker_method_extruder_right.def.json Show resolved Hide resolved
wawanbreton
wawanbreton approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description doesn't really tell that the main addition here is the Method printer :) however this is all good, just one remark/question.

resources/definitions/ultimaker_method.def.json Outdated Show resolved Hide resolved
@HellAholic HellAholic merged commit 5eb8528 into main Jul 2, 2024
7 of 9 checks passed
@HellAholic HellAholic deleted the PP-475-PLA-method branch July 2, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions requested changes

@wawanbreton wawanbreton wawanbreton approved these changes

@pkuiper-ultimaker pkuiper-ultimaker pkuiper-ultimaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanbjorklund @wawanbreton @pkuiper-ultimaker @HellAholic