Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some options to CreateThumbnail to allow for some customisation o… #19419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geekykayaker-anon
Copy link

@geekykayaker-anon geekykayaker-anon commented Jul 22, 2024

Description

Currently the CreateThumbnail plugin writes out the form:
thumbnail begin <x>x<y>
My printer (Creality V3 KE) has a display which shows thumbnails, unfortunately it expects the headers to be formed:
png begin <x>*<y>

In addition to this, Moonraker ONLY seems to accept the first format, and not the second.

In order for thumbnails to appear both on my printer screen AND in Mainsail (which used Moonraker) I have to output each resolution twice, once for each format.

This MR adds support for toggling between:

  • 'thumbnail' and 'png
  • '*' and 'x'

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test 1
I created a project with the old plugin, and set some settings.
My changes didn't impact those settings, and produced the same GCODE output when re-generated

Test 2:
I set inverted the first flag, and then got the expected behaviour in the GCODE.

Test 3:
I set inverted the second flag, and then got the expected behaviour in the GCODE.

Test 4:
With the each of the four combinations of the two new flags as steps, I can get all four combinations of output shown in a CGODE file.

Test Configuration:
MacOs Sequoia
Cura5

Checklist:

…ver the format of the begin block for the image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant