Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cura 12069 move machine nozzle head distance #19483

Merged
merged 15 commits into from
Aug 6, 2024

Conversation

HellAholic
Copy link
Contributor

machine_nozzle_head_distance original definition is in fdmPrinter and not in fdmExtruder. So on the Cura side it's not overriding the setting with the values defined in left extruder of ultimaker s5 (value 2.7 for left extruder) for example but instead takes the default value of 3 in fdmPrinter. So initial impression would be that the Cura results are invalid

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker2.def.json Show resolved Hide resolved
@HellAholic HellAholic marked this pull request as ready for review August 5, 2024 12:18
Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even think we're using this right now? (Maybe we'd have found it earlier if we did already...) In any case, the switch to extruder doesn't seem to give a problem right now.

@HellAholic HellAholic merged commit e3287a1 into main Aug 6, 2024
13 checks passed
@HellAholic HellAholic deleted the CURA-12069-Move_machine_nozzle_head_distance branch August 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants