[CURA-11957] Makerbot file formats don't just have 1 mime-type. #19492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are machines with other mime-types. Prepare for adding that one. last step of CURA-11957 (otherwise solved by previous efforts)
|
❌'s are probably because this is based on a main where that also happens 😅 |
|
This code would benefit from not being two ternaries, and from some documentation about what is going on here. |
|
@fieldOfView Fair. I'll have look to see if I can make it less confusing (and more documented). |
|
So I kept the double ternary, but given how short that line now is, I don't think that's a problem. |
wawanbreton
reviewed
Aug 12, 2024
wawanbreton
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are machines with other mime-types. Prepare for that one.
(otherwise solved by previous efforts)