Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-12119] Fix Cura 5.8 Material Export #19584

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

Frederic98
Copy link
Contributor

@Frederic98 Frederic98 commented Aug 26, 2024

Description

CURA-12119
Upon exporting a .xml.fdm_material profile, Cura writes a 0/0.0 or 1/1.0 as yes or no. The UltiMaker printers then can't import these profiles, as it expects a float in those fields. This PR solves this by explicitly checking if the value is a boolean before converting it to yes/no.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Copied XmlMaterialProfile.py into Cura installation directory and saved .ufp file.

Test Configuration:

  • Operating System: Windows 10

Checklist:

@Frederic98 Frederic98 changed the title Fix Cura 5.8 Material Export [CURA-12119] Fix Cura 5.8 Material Export Aug 26, 2024
@HellAholic HellAholic changed the base branch from main to 5.8 August 28, 2024 11:22
@HellAholic HellAholic changed the base branch from 5.8 to main August 28, 2024 11:22
@HellAholic HellAholic merged commit c80c964 into main Aug 28, 2024
16 checks passed
@HellAholic HellAholic deleted the Fix5.8MaterialExport branch August 28, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants