CuraApplication.py add startReloadAll signal when reloadAll is called #19608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"share/cura/resources/qml/Menus/RecentFilesMenu.qml:39: TypeError: Passing incompatible arguments to C++ functions from JavaScript is not allowed." This was passing the Instantiator index, which is a Number to menu.removeItem which is expecting an object. Add the missing index argument. I found Qt 5.7 had two arguments so it has been there for some time.
share/cura/resources/qml/PrintSetupSelector/Recommended/RecommendedSupportSelector.qml:60:17: Unable to assign [undefined] to int If undefined use Widgets/SingleSettingComboBox.qml default of Cura.ExtruderManager.activeExtruderIndex
If "T(\d*)" was "T(\n*)" it would search for newlines. There isn't any such \d escape character. It should be "T(\\d*)" or r"T(\d*)" going with the latter, to be easier to read and be consistent with other Cura usage. Start python with -Wd or for python 3.12 will raise a SyntaxWarning.
Uranium/UM/Scene/Scene.py depends this startReloadAll, which it will use to cancel file modification reload dialog. Once all the models are reloaded, the file modification reload is not needed.
github-actions
bot
added
the
PR: Community Contribution 👑
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uranium/UM/Scene/Scene.py commit "Scene.py add _hideReloadMessage, connect to startReloadAll" Uranium pull request Ultimaker/Uranium#964 depends on this commit and the signal startReloadAll, which it will
use to cancel file modification reload dialog. Once all the models
are reloaded, the file modification reload dialog is not needed.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: