Cura 12138 export for support option #19644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nallath
requested changes
Sep 30, 2024
| @@ -33,7 +35,7 @@ def setExportModel(self, model: SettingsExportModel) -> None: | |||
| if self._ucp_model != model: | |||
| self._ucp_model = model | |||
|
|
|||
| def _write(self, stream, nodes, mode=WorkspaceWriter.OutputMode.BinaryMode): | |||
| def _write(self, stream, nodes, mode, include_log): | |||
There was a problem hiding this comment.
Include log is a bool trap. I'd also argue that instead of removing the default for the mode, we should just set the include_log to be False by default
There was a problem hiding this comment.
That's right, I have removed the mode default value not because of the include_log, but because it is a "private" method and only called at one place, with a value for the mode. Restoring the default value and setting include_log to False is also fine if you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12138
Requires Ultimaker/Uranium#970
"exported-(package/project)-for-support-timestamp/random-number).3mf"
ex: exported-project-for-support-20240911-13-13.3mf