Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Actions.qml cyclic dependency #19654

Open
wants to merge 1 commit into
base: 5.8
Choose a base branch
from

Conversation

dfries
Copy link

@dfries dfries commented Sep 15, 2024

Description

qt.qml.typeresolution.cycle: Cyclic dependency detected between "File:///Cura/resources/qml/Actions.qml" and "file:///Cura/resources/qml/Actions.qml"

Create a different namespace for Actions to import that has the dependencies it needs, but one that Actions isn't already part of.

While this solution works, I don't know what is extra special about Actions.qml that it can't import Cura without "Cyclic dependency detected" and other components like Menus/MaterialMenu.qml which is registered in cura/CuraApplication.py as a part of qmlRegisterType(QUrl.fromLocalFile(path), "Cura", 1, 0, type_name), but it seems to be okay.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Verified I no longer get "Cyclic dependency detected" on startup
  • Verified that Hot keys, such as F5 still triggers the reload all

Test Configuration:

  • Operating System: Linux Debian

Checklist:

qt.qml.typeresolution.cycle: Cyclic dependency detected between
"File:///Cura/resources/qml/Actions.qml" and
"file:///Cura/resources/qml/Actions.qml"

Create a different namespace for Actions to import that has the
dependencies it needs, but one that Actions isn't already part of.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant