-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PP-511 Method Labs Extruder Materials #19700
base: main
Are you sure you want to change the base?
Conversation
…o Labs extruder profiles, mark these as experimental PP-511
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/2)
resources/quality/ultimaker_method/um_method_labs_basf-ultrafuse-316l-175_0.15mm.inst.cfg
Show resolved
Hide resolved
resources/quality/ultimaker_methodx/um_methodx_labs_basf-ultrafuse-316l-175_0.15mm.inst.cfg
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/2)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
"bridge_fan_speed_3": { "value": "cool_fan_speed_min" }, | ||
"bridge_settings_enabled": { "value": true }, | ||
"bridge_fan_speed_2": { "value": "(cool_fan_speed_max + cool_fan_speed_min) / 2" }, | ||
"bridge_settings_enabled": { "value": true }, | ||
"bridge_skin_density": { "value": 100 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting bridge_settings_enabled is still experimental and should not be used in default profiles
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
"prime_tower_line_width": | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding prime_tower_base_size with the same value (value: 10) as defined in parent definition: ultimaker
"prime_tower_line_width": | |
{ | |
"prime_tower_enable": { "value": "extruders_enabled_count > 1" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
"prime_tower_base_height": { "value": 6 }, | ||
"prime_tower_enable": { "value": "extruders_enabled_count > 1" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding prime_tower_base_height with the same value (value: 6) as defined in parent definition: ultimaker
"prime_tower_base_height": { "value": 6 }, | |
"prime_tower_enable": { "value": "extruders_enabled_count > 1" }, | |
"prime_tower_enable": { "value": "extruders_enabled_count > 1" }, |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
"bridge_settings_enabled": { "value": true }, | ||
"bridge_skin_density_2": { "value": 100 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding bridge_settings_enabled with the same value (value: True) as defined in parent definition: ultimaker
"bridge_settings_enabled": { "value": true }, | |
"bridge_skin_density_2": { "value": 100 }, | |
"bridge_skin_density": { "value": 100 }, |
"bridge_skin_density_3": { "value": 100 }, | ||
"bridge_skin_material_flow": { "value": "material_flow" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding bridge_skin_density_2 with the same value (value: 100) as defined in parent definition: ultimaker
"bridge_skin_density_3": { "value": 100 }, | |
"bridge_skin_material_flow": { "value": "material_flow" }, | |
"bridge_skin_density_3": { "value": 100 }, |
"prime_tower_enable": { "value": "extruders_enabled_count > 1" }, | ||
"prime_tower_line_width": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding prime_tower_base_height with the same value (value: 6) as defined in parent definition: ultimaker
"prime_tower_enable": { "value": "extruders_enabled_count > 1" }, | |
"prime_tower_line_width": | |
"prime_tower_enable": { "value": "extruders_enabled_count > 1" }, |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This is to be reviewed & merged after the other PR for gets merged.
NOTE: Paul asked me to reach out to Bart & Kristel about the getting a new Package ID for the materials I added to cura.json. For now, I used placeholder values and I'll update these with another PR as soon as I receive this information. If you prefer, we can wait for the correct package IDs to merge this PR.
How Has This Been Tested?
I tuned these materials using generic profiles, and once I converted these to branded profiles I sliced and printed one of each material. Additionally, I tested the gcode start update by printing and monitoring the AC fan speeds, as well as manually searching through the print.jsontoolpath file for fan commands.