Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-511 Method Labs Extruder Materials #19700

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

alanbjorklund
Copy link
Contributor

This is to be reviewed & merged after the other PR for gets merged.

  • Adding Jabil SEBS, Polymax PC and Ultrafuse 316L
  • fix for extruder start gcode
  • converted generic profiles to branded 3rd party profiles

NOTE: Paul asked me to reach out to Bart & Kristel about the getting a new Package ID for the materials I added to cura.json. For now, I used placeholder values and I'll update these with another PR as soon as I receive this information. If you prefer, we can wait for the correct package IDs to merge this PR.

How Has This Been Tested?

I tuned these materials using generic profiles, and once I converted these to branded profiles I sliced and printed one of each material. Additionally, I tested the gcode start update by printing and monitoring the AC fan speeds, as well as manually searching through the print.jsontoolpath file for fan commands.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

alanbjorklund and others added 4 commits September 30, 2024 21:52
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

alanbjorklund and others added 3 commits September 30, 2024 21:54
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
"bridge_fan_speed_3": { "value": "cool_fan_speed_min" },
"bridge_settings_enabled": { "value": true },
"bridge_fan_speed_2": { "value": "(cool_fan_speed_max + cool_fan_speed_min) / 2" },
"bridge_settings_enabled": { "value": true },
"bridge_skin_density": { "value": 100 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-experimental-setting ⚠️
Setting bridge_settings_enabled is still experimental and should not be used in default profiles

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
alanbjorklund and others added 2 commits September 30, 2024 21:55
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Comment on lines 377 to 378
"prime_tower_line_width":
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding prime_tower_base_size with the same value (value: 10) as defined in parent definition: ultimaker

Suggested change
"prime_tower_line_width":
{
"prime_tower_enable": { "value": "extruders_enabled_count > 1" },

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
resources/definitions/ultimaker_method_base.def.json Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment on lines 375 to 376
"prime_tower_base_height": { "value": 6 },
"prime_tower_enable": { "value": "extruders_enabled_count > 1" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding prime_tower_base_height with the same value (value: 6) as defined in parent definition: ultimaker

Suggested change
"prime_tower_base_height": { "value": 6 },
"prime_tower_enable": { "value": "extruders_enabled_count > 1" },
"prime_tower_enable": { "value": "extruders_enabled_count > 1" },

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Comment on lines 147 to 148
"bridge_settings_enabled": { "value": true },
"bridge_skin_density_2": { "value": 100 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding bridge_settings_enabled with the same value (value: True) as defined in parent definition: ultimaker

Suggested change
"bridge_settings_enabled": { "value": true },
"bridge_skin_density_2": { "value": 100 },
"bridge_skin_density": { "value": 100 },

Comment on lines 149 to 150
"bridge_skin_density_3": { "value": 100 },
"bridge_skin_material_flow": { "value": "material_flow" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding bridge_skin_density_2 with the same value (value: 100) as defined in parent definition: ultimaker

Suggested change
"bridge_skin_density_3": { "value": 100 },
"bridge_skin_material_flow": { "value": "material_flow" },
"bridge_skin_density_3": { "value": 100 },

Comment on lines 375 to 376
"prime_tower_enable": { "value": "extruders_enabled_count > 1" },
"prime_tower_line_width":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding prime_tower_base_height with the same value (value: 6) as defined in parent definition: ultimaker

Suggested change
"prime_tower_enable": { "value": "extruders_enabled_count > 1" },
"prime_tower_line_width":
"prime_tower_enable": { "value": "extruders_enabled_count > 1" },

alanbjorklund and others added 3 commits September 30, 2024 21:57
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant