Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CURA-12097] Upgrader for 5.8 -> 5.9 version. #19703

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[CURA-12097] Upgrader for 5.8 -> 5.9 version. #19703

merged 1 commit into from
Oct 2, 2024

Conversation

rburema
Copy link
Member

@rburema rburema commented Oct 1, 2024 •
edited by wawanbreton
Loading

wawanbreton
wawanbreton approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, but IMHO the upgrade script would deserve some documentation regarding the purpose of the conversion, indicating that this is following the integration of the gradual flow plugin. On the other hand, this is just an upgrade script, se we don't really care.

Side-note: I only reviewed the Python scripts, I trust you on the 5000+ changed files 😅

@HellAholic HellAholic merged commit 1a7a5bc into main Oct 2, 2024
12 of 14 checks passed
@HellAholic HellAholic deleted the CURA-12097_upgrade_to_59 branch October 2, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawanbreton wawanbreton wawanbreton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rburema @wawanbreton @HellAholic