-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary override #19723
Remove unnecessary override #19723
Conversation
value overrides formula and default value sets the initial value. if value is overridden, the formula cannot update it based on the infill sparse density changes
What is the point of setting this hard-coded 8 value then ? If I'm correct, it will never be used in normal conditions within Cura. I'm fine with it, but at some point, somebody probably put this value for a good reason ? |
Yeah the entire formula needs to be adjusted so the output value is correct for the printer. |
So could you adjust the formula for the printer, so that it gives an 8 at 10%, and something appropriate for other values ? |
the fdmprinter definition formula calculates as 8 for 10% infill
Just removed the override and at 10% the fdmprinter formula calculates as 8, so I don't even know why you would override that. |
Ok, well cool then 😄 |
Do you want to redirect to 5.9 ? |
I'll do a test on a build to confirm and probably cherrypick :P Redirect is also an option. Depending on what is the preferred way. But my assumption was it would be more than 1 line removal change. |
Also cherry picked commit to 5.9 |
Bug fix, value should not be overridden since it cancels out the formula calculating the distance based on the sparse
Update, the override is setting the value to the value that the parent definition would calculate.
Resolves #19716