Fix asymmetrical bead widths #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not a coordinate at all. If negative numbers are desired here, an integer would do. But they are not. We don't want to keep checking that this is negative. Just make the variable type an index, like it is. Found during investigation of CURA-8073.
The check was wrong, in this case. It should be the same as the assertion above it. Found during investigation of issue CURA-8073.
Instead of with the width at the far end of the line segment, print it with the average. Previously, the width of a line would depend on the direction in which you were printing it. Quite often, as a path went into a narrow peak and back out, one side of this peak would be printed with a small line width (the peak being narrow) and as the nozzle goes back out, that segment would be printed with a large line width (the base being wider). This is inconsistent and leads to larger flow changes than necessary. Often this would also vary from layer to layer (a different bug) which would look extra messy. Fixes issue CURA-8073.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of with the width at the far end of the line segment, print it with the average.
Previously, the width of a line would depend on the direction in which you were printing it. Quite often, as a path went into a narrow peak and back out, one side of this peak would be printed with a small line width (the destination in the peak being narrow) and as the nozzle goes back out, that segment would be printed with a large line width (the destination at the base being wider). This is inconsistent and leads to larger flow changes than necessary. Often this would also vary from layer to layer, a different bug, which looks extra messy.
Before this change:
After this change:
The first two commits are clean-ups of things that I found during this investigation, and don't affect the outcome. Tests seem to be failing due to the build environment in the CI server still.
Fixes issue CURA-8073. This doesn't fix yet that the lines exceed the volume of the original model significantly, but I did find the cause of that and reported that in the CCB just now.