Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CURA-11875] Fix Tree support going through the model #2118

Merged
merged 2 commits into from
Jul 11, 2024
Merged

[CURA-11875] Fix Tree support going through the model #2118

merged 2 commits into from
Jul 11, 2024

Conversation

rburema
Copy link
Member

@rburema rburema commented Jul 10, 2024

Just clip the offending part out if it intersects too much with the model.

wawanbreton
wawanbreton requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@wawanbreton wawanbreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the code, so just doing a syntax check.
Just one optimization remark, otherwise looks good.

src/TreeSupport.cpp Show resolved Hide resolved
@HellAholic HellAholic merged commit e29a1ef into 5.8 Jul 11, 2024
18 checks passed
@HellAholic HellAholic deleted the CURA-11875_fix_treesupport_through_model branch July 11, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawanbreton wawanbreton wawanbreton requested changes

@HellAholic HellAholic HellAholic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rburema @wawanbreton @HellAholic