Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Np 351 adding gcode header to emscription #2136

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Np 351 adding gcode header to emscription #2136

merged 3 commits into from
Aug 21, 2024

Conversation

saumyaj3
Copy link
Contributor

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Operating System:

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

jellespijker
jellespijker approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jellespijker jellespijker merged commit 2a6b939 into NP-327_emscripten_communication Aug 21, 2024
25 checks passed
@jellespijker jellespijker deleted the NP-351-adding-gcode-header-to-emscription branch August 21, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jellespijker jellespijker jellespijker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saumyaj3 @jellespijker