-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme: configuring and compilation #116
base: master
Are you sure you want to change the base?
Conversation
Crude attempt at updating the readme regarding configuring and compilation
``` | ||
Use the Makefile to compile & upload the firmware, for example: | ||
``` | ||
make UPLOAD_PORT=/dev/ttyACM0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need the upload_port for the make command :) can you verify this and then update your PR/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, you where right, didn't need it. I updated the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And while i'm typing 'could you also just squash your commits into one' I realized this was about UM2 marlin firmware, which as far as I recall, can still be built using Arduino. So maybe add it as an alternative/optional flow.
Sorry for bike shedding over such a simple change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky since I never tried this with the Arduino IDE. I just kept the basics intact. I did choose for cloning, since that makes development and contributing easier.
I understand it's now possible for the maintainers of Github repo's to squash commits when merging; https://github.com/blog/2141-squash-your-commits
Let me know if you want other tweaks.
Crude attempt at updating the readme regarding configuring and compilation