Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme: configuring and compilation #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

peteruithoven
Copy link

Crude attempt at updating the readme regarding configuring and compilation

Crude attempt at updating the readme regarding configuring and compilation
```
Use the Makefile to compile & upload the firmware, for example:
```
make UPLOAD_PORT=/dev/ttyACM0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the upload_port for the make command :) can you verify this and then update your PR/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, you where right, didn't need it. I updated the example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And while i'm typing 'could you also just squash your commits into one' I realized this was about UM2 marlin firmware, which as far as I recall, can still be built using Arduino. So maybe add it as an alternative/optional flow.

Sorry for bike shedding over such a simple change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky since I never tried this with the Arduino IDE. I just kept the basics intact. I did choose for cloning, since that makes development and contributing easier.

I understand it's now possible for the maintainers of Github repo's to squash commits when merging; https://github.com/blog/2141-squash-your-commits

Let me know if you want other tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants