Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed M105 response for EXTRUDERS > 1 #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Idelmaeaen
Copy link

Changed the resonse of M105 for printers with dual (or more)
extruders.
Now the actual and target temperature and also the output
power is
reoprted for each hotend.
Tested with:
-Simplify3D V2.2.2
(shows the temperature of both extruders at the
same
time)
-Repetier-Host V1.0.6 (Graph shows only the actual selected
hotend, the
status bar shows both hotends)

Changed the resonse of M105 for printers with dual (or more)
extruders.
Now the actual and target temperature and also the output
power is
reoprted for each hotend.
Tested with:
-Simplify3D V2.2.2
(shows the temperature of both extruders at the
same
time)
-Repetier-Host V1.0.6 (Graph shows only the actual selected
hotend, the
status bar shows both hotends)
@daid
Copy link
Contributor

daid commented May 6, 2015

@foosel Your opinion on this?

@foosel
Copy link

foosel commented May 6, 2015

This would result in things looking like this, right?

ok T:<tooltemp> /<tooltarget> B:<bedtemp> /<bedtarget> B@:<bedpower> @:<toolpower> T0:<tool0temp> /<tool0target> @0:<tool0power> T1:...

If so, that should be fine. Just from a purely visual point of view I find it a bit unintuitive that the power data for the currently selected tool follows after the bed segment though, that appears to be a bit out of order, but then it's always been like this in that the bed stuff "interrupts" the current tool information.

@daid
Copy link
Contributor

daid commented May 6, 2015

I'm not a huge fan of the tool power outputs, as they are pretty much useless anyhow. (If you enable PID_DEBUG you see the output has much more spread then you could ever see with M105)

@Idelmaeaen
Copy link
Author

@foosel: Yes it looks as you wrote...
You are right that the arrangement of the data is not really logical. I took the arrangement from the Repetier Firmware. See here:
https://github.com/repetier/Repetier-Firmware/blob/master/src/ArduinoDUE/Repetier/Commands.cpp#L147-L188

@ckielstra
Copy link
Contributor

@Idelmaeaen: You asked for a new pull request from this branch for the new M99 feature. Don't do that. Please create a new branch for each new feature or bug fix. Mixing several issues in one branch creates confusion and overhead.

So, if you want the new M99 command merged into master, then create a new branch for this feature. Also explain why you think this new feature is useful to other people, right now it is not clear to me as to why I would use it. Can you give an example of when people would use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants