Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth Of Field #1250

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

sellendk
Copy link
Collaborator

@sellendk sellendk commented Feb 8, 2024

Introducing a new DepthOfField module that implements depth of field.
The depth of field is controlled by 3 parameters:

  • Strength: controls the sampling kernel scale in the computation pass and the amount of blending
  • FocalDistance: distance to the center of the sharp area
  • FocalRange: sharp area is [FocalDistance - FocalRange, FocalDistance + FocalRange]

Summary of Changes

Adds a new module "DepthOfField" to the compositing_gl plugin.

TODO

Copyright

References and Context

In reference to Issue #671.
GPU Zen 01 - Advanced Rendering Technique - Practical Gather-based Bokeh Depth of Field

Test Instructions

Add the new DepthOfField module to the mesh_dfr_gltf_example.lua project.

@sellendk sellendk added the feature Provides a new feature. label Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

Style check found formatting issues! Comment /format, to automatically commit the suggested changes.

Copy link

github-actions bot commented Feb 8, 2024

Style check found formatting issues! Comment /format, to automatically commit the suggested changes.

Copy link

github-actions bot commented Feb 8, 2024

Style check found formatting issues! Comment /format, to automatically commit the suggested changes.

@sellendk
Copy link
Collaborator Author

sellendk commented Feb 9, 2024

/format

Copy link

github-actions bot commented Feb 9, 2024

Style check found formatting issues! Comment /format, to automatically commit the suggested changes.

Copy link

github-actions bot commented Feb 9, 2024

Formatting failed! For details, please check the log!

Copy link

github-actions bot commented Feb 9, 2024

Style check found formatting issues! Comment /format, to automatically commit the suggested changes.

@sellendk
Copy link
Collaborator Author

sellendk commented Feb 9, 2024

/format

@sellendk sellendk changed the title Depthoffield Depth Of Field Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Provides a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants