feature: create base tpdm/edfi_3 models iteration 2 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzakharko
force-pushed
the
feature/create-base-tpdm-models-step2
branch
from
bdd6b79
to
eba633e
Compare
vzakharko
force-pushed
the
feature/create-base-tpdm-models-step2
branch
from
eba633e
to
aad2a1e
Compare
holdorph
reviewed
Jul 22, 2024
There was a problem hiding this comment.
This file is duplicated from what is in PR #10
holdorph
reviewed
Jul 22, 2024
There was a problem hiding this comment.
I don't think this is needed. person I think is just in the base namespace, I don't think there is a second version in the tpdm namespace. you can double check with the documentation here: https://schema.ed-fi.org/datahandbook-v510/index.html#/Person26772476-74ad-430a-bcb2-f49102f1300f anything that is in the TPDM namespace will have "(TPDM)" at the end of the name. Compare "Person" to "Candidate (TPDM)" as examples.
vzakharko
force-pushed
the
feature/create-base-tpdm-models-step2
branch
from
8403462
to
b27fdcf
Compare
vzakharko
force-pushed
the
feature/create-base-tpdm-models-step2
branch
from
b27fdcf
to
e849ae3
Compare
vzakharko
force-pushed
the
feature/create-base-tpdm-models-step2
branch
from
4bd05da
to
93b172c
Compare
vzakharko
force-pushed
the
feature/create-base-tpdm-models-step2
branch
from
93b172c
to
f9f888d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.