Feature tzaware #110
Merged
Feature tzaware #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally converting dates with timezones to naive UTC so that dates with timezones can be passed to JulianDayFromDate and date2num. Implicitly adds support to utime.date2num
2.7 did not have the timezone class with the utc object, but the documentation included a working example.
Testing for py2.7 is challenging because I do not readily have that environment. Using TravisCI to find 2.7 bugs
py.test is only runing all test_ or runTest, so runTest was renamed as test_tz_naive
|
Looks good, merging now. Thanks @barronh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally converting dates with timezones to naive UTC so that dates with timezones can be passed to JulianDayFromDate and date2num. Implicitly adds support to utime.date2num.
Functionality and tests have been added. Including python2.7 capabilities.