Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netcdf4 keywords incorrectly used with classic model in ncgen #1750

Open
DennisHeimbigner opened this issue Jun 3, 2020 · 0 comments
Open

Netcdf4 keywords incorrectly used with classic model in ncgen #1750

DennisHeimbigner opened this issue Jun 3, 2020 · 0 comments

Comments

@DennisHeimbigner
Copy link
Collaborator

Built-in keywords like string, which is netcdf-4 specific, are being applied
to netcdf-3 cdl files in ncgen. So if a user declares a dimension named
"string" in a classic .cdl file, it causes an error.
@DennisHeimbigner DennisHeimbigner mentioned this issue Jun 5, 2020
Merged
DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this issue Apr 13, 2021
@DennisHeimbigner
Fix the handling of certain alias types on CDL files.
ac42162 
re: Unidata#1977

PR Unidata#1753, changed ncgen
to allows certain type names to be used as identifiers in
selected situations.

An unwanted side effect was that existing type aliases no longer
were accepted by ncgen. Specifically, using the "long" type
caused an error.

I was able to figure out a better solution to the original
problem (Unidata#1750)
that also fixes this problem as well.

This PR fixes that problem in ncgen/ncgen.l,
and adds tests to ncdump/test_keywords.sh
@DennisHeimbigner DennisHeimbigner mentioned this issue Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DennisHeimbigner