Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-wired use of NC_MAX_DIMS #150

Merged
merged 1 commit into from
Nov 12, 2015
Merged

Remove hard-wired use of NC_MAX_DIMS #150

merged 1 commit into from
Nov 12, 2015

Conversation

gdsjaar
Copy link
Contributor

@gdsjaar gdsjaar commented Nov 11, 2015

Replace static array dimensioned to NC_MAX_DIMS with dynamic memory allocation of correctly sized array.

Replace static array dimensioned to NC_MAX_DIMS with dynamic memory allocation of correctly sized array.
@DennisHeimbigner
Copy link
Collaborator

I was in the process of making the same change, but this is equivalent, so we can
use it.

@gdsjaar
Copy link
Contributor Author

gdsjaar commented Nov 11, 2015

Thanks, hope I didn't waste too much of your time. I saw this while looking at the NX_MAX_DIMS issue and decided that it was probably a non-controversial change and might buy me some karma to use later ;-)
..Greg

"A supercomputer is a device for turning compute-bound problems into I/O-bound problems"

From: DennisHeimbigner <[email protected]mailto:[email protected]>
Reply-To: Unidata/netcdf-c <[email protected]mailto:[email protected]>
Date: Wednesday, November 11, 2015 at 2:08 PM
To: Unidata/netcdf-c <[email protected]mailto:[email protected]>
Cc: "Sjaardema, Gregory D" <[email protected]mailto:[email protected]>
Subject: [EXTERNAL] Re: [netcdf-c] Remove hard-wired use of NC_MAX_DIMS (#150)

I was in the process of making the same change, but this is equivalent, so we can
use it.

Reply to this email directly or view it on GitHubhttps://github.com//pull/150#issuecomment-155881056.

@WardF
Copy link
Member

WardF commented Nov 12, 2015

Looks good so far; running regression tests via Docker unidata/nctest images to rule out any unforeseen impacts on the fortran, C++ or python interfaces.

@WardF WardF merged commit 2ae0e45 into Unidata:master Nov 12, 2015
WardF pushed a commit that referenced this pull request Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants