Fix cmake search for Blosc and SZip #2255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake does not search for Blosc or SZip libraries due to use of bang (!) rather than NOT for negation on lines 1072 and 1084 of CMakeLists.txt. This commit fixes this issue. Resolves Unidata#2254
|
|
|
This pull request introduces 1 alert when merging dc38f98 into 5265520 - view on LGTM.com new alerts:
|
|
Sigh, this is what comes of adapting code from automake. Thanks for catching this. |
|
Thank you, working my way up the list from oldest-newest for the 4.9.0 release, I'll make sure this is included! |
|
Looks like this gets fixed in PR #2245 |
|
@DennisHeimbigner, good catch. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake does not search for Blosc or SZip libraries due to use of bang (!) rather
than NOT for negation on lines 1072 and 1084 of CMakeLists.txt. This commit
fixes this issue.
Resolves #2254