Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix many warnings in libnczarr #2852

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Jan 31, 2024

  1. Configuration menu
    Copy the full SHA
    51073cb View commit details
    Browse the repository at this point in the history
  2. Change len member of NC_ATT_INFO_T to size_t

    More consistent with similar structs, and generates fewer warnings
    ZedThree committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    013af12 View commit details
    Browse the repository at this point in the history
  3. Switch some int/mode_t confusion

    Some mix-up here: `mode_t` was used for some netCDF-specific modes,
    and `int` used for some POSIX-specific modes
    ZedThree committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    585e322 View commit details
    Browse the repository at this point in the history
  4. Fix some sign conversion warnings in libnczarr functions/types

    Try to be more consistent in use of `size_t` across internal library declarations
    ZedThree committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3537781 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Fix loop conditional in NCZ_filter_finalize

    `loaded_plugins_max` is *not* the total number of loaded plugins, but
    the max ID, and defaults to `-1`. This clashes with the change of the
    index to `size_t`
    ZedThree committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    f8da95a View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Merge branch 'main' into silence-libnczarr-warnings

    * main: (248 commits)
      Updated Release Notes.
      A bit of cleanup for now, more to follow, but moving on to other roadblocks.
      Comment out debugging messages, will remove before final merge.  Clean up the logic, remove some rough edges.
      Add a filter to process options and report deprecation warning.
      Remove dangling define in netcdf_meta.h template file.
      No effect other than to remove a personal annoyance I introduced in the first place.
      Updated the nc-config script with the following:
      adding deprecation error for usage of NETCDF_ENABLE_NETCDF4
      removing cmake alias variable for netcdf4
      removing script
      replacing something that removes semicolons
      another one
      fixing some that were missing?
      removing variables
      Replacing NC_USE_STATIC_CRT with NETCDF_USE_STATIC_CRT
      Replace NC_FIND_SHARED_LIBS with NETCDF_FIND_SHARED_LIBS
      Replace ENABLE_XGETOPT with NETCDF_ENABLE_XGETOPT
      Replace ENABLE_UNIT_TESTS with NETCDF_ENABLE_UNIT_TESTS
      Replace ENABLE_TESTS with NETCDF_ENABLE_TESTS
      Replace ENABLE_STRICT_NULL_BYTE_HEADER_PADDING with NETCDF_ENABLE_STRICT_NULL_BYTE_HEADER_PADDING
      ...
    ZedThree committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0df2958 View commit details
    Browse the repository at this point in the history
  2. Conditionally mark variable as unused

    Also delete actually unused variable
    ZedThree committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    dac5355 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7c1c78 View commit details
    Browse the repository at this point in the history