-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netcdf-c branch ghpull-375 breaks netcdf4-python tests #645
Comments
If you have docker available, you can duplicate this easily as follows:
|
To run ONLY the python tests:
|
So that test fails because it is requesting data from a slice that is outside the actual bound of the data. Previously, this would return an empty array; with these changes to netcdf-c, now it seems that this code is triggering: ierr = nc_get_vars(self._grpid, self._varid,
startp, countp, stridep, data.data)
if ierr == NC_EINVALCOORDS:
raise IndexError So we need to adapt somehow... |
jswhit
added a commit
that referenced
this issue
Apr 21, 2017
pull request merged that should fix the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm in the process of merging a pull request submitted by Wei-Keng Liao (full history here: Unidata/netcdf-c#319 working branch is ghpull-375). Regression tests on the branch result in the following error in the netcdf4-python tests:
It has been a long time coming, but we are preparing to merge this into master. Since there are netcdf4-python failures, I thought I should post this information here so there is some warning (and chance for feedback; if this is a big problem let us know!) instead of rudely allowing the tests to fail with no warning :).
The text was updated successfully, but these errors were encountered: