Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use androidx.appcompat for better AlertDialog styling #93

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Aug 9, 2024

  1. chore(deps): Update JVM toolchain, kotlin, gradle dependencies

    Remove unnecessary API dependency on Kotlin stdlib.
    nikclayton committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    e45c740 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. fix: Re-register if the active distributor was deleted

    The user might register with a distributor, and then delete the
    distributor app.
    
    If that happens the user is not prompted if there are no distributors,
    and re-registration does not happen.
    
    Fix this by checking the ack'ed distributor is still in the list of
    installed distributors.
    nikclayton committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    52ba3e4 View commit details
    Browse the repository at this point in the history
  2. fix: Update "No distributor found" dialog

    Previous code ignored the dialog's default layout and set its own
    textview. I think this was so a LinkMovementMethod could be set on the
    message.
    
    This meant the view didn't follow normal Android dialog dimensions
    (e.g., padding, margins, text layout), and looked out of place.
    
    Fix this. Use the normal AlertDialog message. Set an onShowListener
    that sets the LinkMovementMethod when the dialog is shown.
    nikclayton committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    5d452a0 View commit details
    Browse the repository at this point in the history
  3. fix(l10n): Use resource strings for default dialog string resources

    The strings used in default dialogs were hardcoded. This meant they
    couldn't be translated, or use the default platform strings (e.g.,
    android.R.string.ok).
    
    Fix that. Convert `RegistrationDialogContent`, `NoDistributorDialog`,
    and `ChooseDialog` to interfaces, and provide implementations of those
    interfaces that
    nikclayton committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    65d4e6f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    650ab49 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. Configuration menu
    Copy the full SHA
    b0e68b0 View commit details
    Browse the repository at this point in the history