fix(ai-module): add retries in the requests #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| attempts += 1 | ||
| if attempts >= max_retries: | ||
| raise RetryError(f"Failed after {max_retries} attempts: {e}") | ||
| time.sleep(2) |
There was a problem hiding this comment.
this is not exponential backoff
| try: | ||
| response = await requestor.request_async(method_, url_, params) | ||
| return convert_to_unique_object(response, user_id, company_id, params) | ||
| except APIError as e: |
There was a problem hiding this comment.
please also make sure that only a select few errors are leading to retrys
like the one I iinked
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, I actually checked this, it specifically raised
"unique_sdk._error.APIError: There was a problem proxying the request"
in the log.
although our errors are kind of general exceptions and not catching any specific one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://unique-ch.atlassian.net/browse/UN-8357