-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update polkadot to v0.9.43 #968
Conversation
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
@@ -31,7 +34,10 @@ parameter_types! { | |||
pub const GasPerSecond: u64 = ReadsPerSecond::get() * 2100; | |||
pub const WeightTimePerGas: u64 = WEIGHT_REF_TIME_PER_SECOND / GasPerSecond::get(); | |||
|
|||
pub const WeightPerGas: Weight = Weight::from_parts(WeightTimePerGas::get(), 0); | |||
pub const BytesReadPerSecond: u64 = ReadsPerSecond::get() * EVM_SLOAD_PROOF_SIZE; | |||
pub const ProofSizePerGas: u64 = 0; //WEIGHT_REF_TIME_PER_SECOND / GasPerSecond::get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Такая простая формула тут не работает по разным причинам, нормальная токеномика будет проставлена после разбирательств с frontier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=> Будет исправлено после задачи по бенчмаркингу открытия EVM контекста
2b81a36
to
1b4b057
Compare
@@ -1111,32 +1133,42 @@ where | |||
|
|||
#[cfg(feature = "pov-estimate")] | |||
backend, | |||
eth_backend: frontier_backend.clone(), | |||
// eth_backend, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
overrides.clone(), | ||
eth_backend, | ||
3, | ||
0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Что это за значения?
@@ -178,6 +217,9 @@ mod pallet { | |||
} else { | |||
<MinGasPriceOverride<T>>::kill(); | |||
} | |||
// This code should not be called in production, but why keep development in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but why keep development
Мб имелось в виду "we keep"? Ибо это не звучит как вопрос.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это вопрос, просто риторический)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
Why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А кто знает ответ?)
Чет не пойму что тут к чему :D
@@ -20,6 +20,9 @@ use up_common::constants::*; | |||
|
|||
pub type CrossAccountId = pallet_evm::account::BasicCrossAccountId<Runtime>; | |||
|
|||
// Assuming PoV size per read is 96 bytes: 16 for twox128(Evm), 16 for twox128(Storage), 32 for storage key, and 32 for storage value | |||
const EVM_SLOAD_PROOF_SIZE: u64 = 96; | |||
|
|||
// ~~Assuming slowest ethereum opcode is SSTORE, with gas price of 20000 as our worst case~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Коль это "very wrong", то мб еще отдельно скажем, что это TODO и будет сделано "тогда-то"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это уже сделано, тут объяснена история принятия такого решения, потому что оно не интуитивное.
В мунбиме и прочих тут константа из головы, у нас стоимость описана формулой
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Просто из коммента не ясно что оно уже исправлено, а ощущение, что это надо исправить
No description provided.