Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: generalize spender #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Thomas-Smets
Copy link

@Thomas-Smets Thomas-Smets commented Oct 12, 2023

Protocols integrating Permit2 will probably reuse the utils provided in this repo for their tests.
But the spender in their tests will most likely not be the test-contract itself.

Finding why the signature verification fails due to the hard-coded spender requires quite some knowledge of both Foundry and how certificates work, and is not that straightforward.

By generalising the spender, integrations will be sped up and better tested.
Alternatively I can also move the spender to the structs in ISignatureTransfer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant