Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add avax, use sdk-core constants #246

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Conversation

lynnshaoyu
Copy link
Contributor

@lynnshaoyu lynnshaoyu commented Jun 21, 2023

Changes:

  • Use ChainId from sdk-core instead of locally defined chainId enum.
  • Add support for avalanche
Screen Shot 2023-06-21 at 9 43 43 PM

@lynnshaoyu lynnshaoyu marked this pull request as draft June 22, 2023 01:29
@lynnshaoyu lynnshaoyu changed the title feat: add avax feat: add avax, use sdk-core constants Jun 22, 2023
@lynnshaoyu lynnshaoyu marked this pull request as ready for review June 22, 2023 16:13
@lynnshaoyu lynnshaoyu marked this pull request as draft June 22, 2023 17:20
package.json Outdated
"@uniswap/token-lists": "^1.0.0-beta.24",
"@uniswap/universal-router-sdk": "^1.3.0",
"@uniswap/sdk-core": "^3.2.6",
"@uniswap/smart-order-router": "^3.13.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this 3.13.5, and remove the caret at the beginning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lynnshaoyu lynnshaoyu requested a review from mikeki June 22, 2023 21:37
@lynnshaoyu lynnshaoyu marked this pull request as ready for review June 22, 2023 21:38
@lynnshaoyu lynnshaoyu merged commit 0e72b89 into main Jun 22, 2023
3 checks passed
lynnshaoyu added a commit that referenced this pull request Jun 22, 2023
lynnshaoyu added a commit that referenced this pull request Jun 22, 2023
Revert "feat: add avax, use sdk-core constants (#246)"

This reverts commit 0e72b89.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants