Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alarm): exclude very low volume chains from 4xx alarm (no route) #810

Merged
merged 3 commits into from
Aug 14, 2024
Merged

fix(alarm): exclude very low volume chains from 4xx alarm (no route) #810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5f3f6e
fix(alarm): exclude very low volume chains from 4xx alarm (no route)
xrsv Aug 10, 2024
debd26d
Merge branch 'main' into vasilis/SEV3-4XXAlarm-alarm-adjust
xrsv Aug 14, 2024
4c7d2cb
fix:prettier
xrsv Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/stacks/routing-api-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,10 @@ export class RoutingAPIStack extends cdk.Stack {
return
}
const alarmName = `RoutingAPI-SEV3-4XXAlarm-ChainId: ${chainId.toString()}`
// We only want to alert if the volume is high enough over default period (5m) for 4xx errors (no route).
const invocationsThreshold = 500
const metric = new MathExpression({
expression: '100*(response400/invocations)',
expression: `IF(invocations > ${invocationsThreshold}, 100*(response400/invocations), 0)`,
usingMetrics: {
invocations: new aws_cloudwatch.Metric({
namespace: 'Uniswap',
Expand Down
Loading