Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v3-sdk): Adding extra fee tiers for V3 #99

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

xrsv
Copy link
Collaborator

@xrsv xrsv commented Sep 17, 2024

Description

Adding 3 more fee tiers in FeeAmount enum
This is needed for SOR routing updates.

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

Based on offline discussions, this addition of new tiers shouldn't affect anything.

(Optional) Feedback Focus

Please let me know if there is any concern for adding those new fee tiers here.

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@xrsv xrsv requested a review from a team as a code owner September 17, 2024 22:01
Copy link

graphite-app bot commented Sep 17, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/17/24)

1 reviewer was added and 1 assignee was added to this PR based on 's automation.

Copy link
Member

@jsy1218 jsy1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep in general, tickspacing = 2 * fee bps, except for 1% fee bps. Waiting on protocol team to confirm the tickspacings are correct.

@xrsv xrsv merged commit 93df082 into main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants