feat: mixed routing with v4 hookless pools #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/[email protected], npm/@uniswap/[email protected] |
jsy1218
changed the title
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (09/12/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
xrsv
approved these changes
Sep 13, 2024
jsy1218
force-pushed
the
siyujiang/route-195-implement-mixed-quoter-with-v2v3v4-with-hookless-quoter-and
branch
2 times, most recently
from
3f3af2d
to
9d56196
Compare
This reverts commit ee0b207.
jsy1218
force-pushed
the
siyujiang/route-195-implement-mixed-quoter-with-v2v3v4-with-hookless-quoter-and
branch
from
8758515
to
0f2b53b
Compare
jsy1218
deleted the
siyujiang/route-195-implement-mixed-quoter-with-v2v3v4-with-hookless-quoter-and
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
current mixed quoter doesn't support mixed routing with v4 pools.
What is the new behavior (if this is a feature change)?
we will have a conditional to determine which version of mixed quoter to hit against, depending on whether any mixed route contains a v4 pool.
Other information:
It depends on feat(router-sdk): support mixed route with v4 route sdks#94 and feat(sdk-core): add mixed quoter v2 property sdks#95 to merge first.