Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better JDK names in unsupported version warning #2635

Closed
tyuldashev opened this issue Oct 2, 2023 · 0 comments · Fixed by #2646
Closed

Use better JDK names in unsupported version warning #2635

tyuldashev opened this issue Oct 2, 2023 · 0 comments · Fixed by #2646
Assignees
@Vassiliy-Kudryashov
Labels
comp-ui Improvements of plugin UI appearence and functionality ctg-bug Issue is a bug priority-minor Issue is rated as minor

Comments

@tyuldashev
Copy link
Collaborator

Description
In warning about unsupported JDK version currently some name of constant or something like that is used, e.g. JDK_1_8, JDK_11. It would be more user friendly if their actual version names are used, like 1.8 or 11

To Reproduce

  1. Install UnitTestBot plugin built from main in IntelliJ IDEA
  2. Open some project where Project or current module JDK is set to 21 (latest LTS version).
  3. Invoke test generation dialog.

Actual behavior
Dialog with warning has been shown.

image

Expected behavior
Text in the warning would be something like:
JDK version 21 is not supported, use 1.8, 11 or 17 versions instead. Setup JDK.

Note I've also suggest to use JDK instead of SDK to be more specific if it's Java only warning.
@tyuldashev tyuldashev added ctg-bug Issue is a bug comp-ui Improvements of plugin UI appearence and functionality priority-minor Issue is rated as minor labels Oct 2, 2023
Vassiliy-Kudryashov pushed a commit that referenced this issue Oct 4, 2023
Use better JDK names in unsupported version warning #2635
d3f53ce
@Vassiliy-Kudryashov Vassiliy-Kudryashov mentioned this issue Oct 4, 2023
Merged
6 tasks
Vassiliy-Kudryashov added a commit that referenced this issue Oct 5, 2023
@Vassiliy-Kudryashov
Make JDK names more readable (in unsupported version warning) (#2646)
4bb4329 
Use better JDK names in unsupported version warning #2635
alisevych pushed a commit that referenced this issue Oct 5, 2023
@Vassiliy-Kudryashov @alisevych
Make JDK names more readable (in unsupported version warning) (#2646)
25b6ab4 
Use better JDK names in unsupported version warning #2635

(cherry picked from commit 4bb4329)
Vassiliy-Kudryashov added a commit that referenced this issue Oct 9, 2023
@Vassiliy-Kudryashov @alisevych
Update plugin.xml and plugin-specific services to actual IntelliJ API (…
e3f5516 
…#2654)

* Update change notes in plugin.xml for release 2023.10

* Make JDK names more readable (in unsupported version warning) (#2646)

Use better JDK names in unsupported version warning #2635

(cherry picked from commit 4bb4329)

* Correct plugin description in plugin.xml

* Update plugin.xml and plugin-specific services to actual API

---------

Co-authored-by: Vassiliy.Kudryashov <[email protected]>
Co-authored-by: Alena Lisevych <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vassiliy-Kudryashov Vassiliy-Kudryashov

Labels
comp-ui Improvements of plugin UI appearence and functionality ctg-bug Issue is a bug priority-minor Issue is rated as minor
Projects
UTBot Java
Archived in project
Milestone
No milestone
2 participants
@Vassiliy-Kudryashov @tyuldashev