-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace z3 jar files with KSMT dependency #1941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaelmBleidd
added
ctg-enhancement
New feature, improvement or change request
comp-symbolic-engine
Issue is related to the symbolic execution engine
lang-java
Issue is related to Java support
labels
Mar 13, 2023
CaelmBleidd
requested review from
denis-fokin,
sergeypospelov,
Damtev and
Domonion
March 13, 2023 16:56
Domonion
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Damtev
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
utbot-framework-test/src/test/kotlin/org/utbot/framework/z3/extension/Z3ExtensionForTests.kt
Show resolved
Hide resolved
utbot-framework-test/src/test/kotlin/org/utbot/framework/z3/extension/Z3ExtensionForTests.kt
Show resolved
Hide resolved
CaelmBleidd
force-pushed
the
caelmbleidd/z3_version
branch
from
March 14, 2023 14:08
ac802c3
to
e026b66
Compare
denis-fokin
pushed a commit
that referenced
this pull request
Mar 15, 2023
(cherry picked from commit 88927a9)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp-symbolic-engine
Issue is related to the symbolic execution engine
ctg-enhancement
New feature, improvement or change request
lang-java
Issue is related to Java support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace prebuilt Z3 jars with KSMT dependency
Description
I've replaced prebuilt Z3 jars with KSMT dependency. It has three consequences:
jar
along with our source code in our repository and build it by hand0.4.3
works withZ3 4.11.2
. Because of that, we have to generalize Z3 expressions with typesHow to test
Automated tests
Since it is a global change, all automatic tests are affected by it.
Manual tests
It was tested with automatic tests on the pipeline on Ubuntu, locally on Windows and Mac with both M1 Pro and Intel-based processors.
Self-check list