Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct casts for negative numbers and test file name for inner classes #2518

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Correct casts for negative numbers and test file name for inner classes #2518

merged 7 commits into from
Aug 17, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Aug 15, 2023 •
edited
Loading

Description

Fixes # (2514)
Also fixes # (2515)

How to test

Automated tests: standard pipeline as a set of regression checks
Manual tests: scenarios from issue

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug labels Aug 15, 2023
IlyaMuravjov
IlyaMuravjov approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it would also add unnecessary braces for negative infinity, but I think it's fine.

@EgorkaKulikov EgorkaKulikov linked an issue Aug 16, 2023 that may be closed by this pull request
Uncompilable test for inner class, due improper naming #2515
Closed
@EgorkaKulikov EgorkaKulikov changed the title Correct casts for negative numbers Correct casts for negative numbers and test file name for inner classes Aug 16, 2023
@EgorkaKulikov EgorkaKulikov merged commit 870153f into main Aug 17, 2023
35 checks passed
@EgorkaKulikov EgorkaKulikov deleted the egor/cast_negative_numbers branch August 17, 2023 08:53
@EgorkaKulikov EgorkaKulikov linked an issue Aug 17, 2023 that may be closed by this pull request
Uncompilable test is generated by fuzzer for Collections test #2514
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaMuravjov IlyaMuravjov IlyaMuravjov approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug
Projects
None yet
Milestone
No milestone
2 participants
@EgorkaKulikov @IlyaMuravjov