Fix wrapper concrete types #964
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaelmBleidd
requested changes
Sep 20, 2022
utbot-framework/src/main/kotlin/org/utbot/engine/ArrayObjectWrappers.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/ArrayObjectWrappers.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/CollectionWrappers.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/StreamWrappers.kt
Outdated
Show resolved
Hide resolved
dtim
requested changes
Sep 21, 2022
utbot-framework/src/main/kotlin/org/utbot/engine/ObjectWrappers.kt
Outdated
Show resolved
Hide resolved
utbot-framework-test/src/test/kotlin/org/utbot/examples/casts/InstanceOfExampleTest.kt
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/engine/ArrayObjectWrappers.kt
Outdated
Show resolved
Hide resolved
| @@ -137,6 +139,9 @@ abstract class BaseContainerWrapper(containerClassName: String) : BaseOverridden | |||
| } | |||
| } | |||
|
|
|||
| override fun getPotentialPossibleTypes(type: Type): Set<Type> = | |||
| setOf(Scene.v().getSootClass(chooseClassIdWithConstructor(type.classId).canonicalName).type) | |||
There was a problem hiding this comment.
I suppose that this code can return not only concrete classes but interfaces as well. It seems that it may be a bit dangerous. What do you think?
There was a problem hiding this comment.
Are you sure? chooseClassIdWithConstructor must return class with callable constructor (I suppose) that we use for creation assemble model.
SBOne-Kenobi
force-pushed
the
sbone/fix-wrapper-concrete-types
branch
from
1f3de41
to
c390666
Compare
CaelmBleidd
requested changes
Sep 25, 2022
Comment on lines
+268
to
+271
| val possibleObjectTypes = Scene.v().classes.map { it.type } | ||
| return possibleObjectTypes.mapTo(mutableSetOf()) { | ||
| it.arrayType | ||
| } |
There was a problem hiding this comment.
Now it contains all the types, including interfaces, abstract classes, artificial entities, our own classes, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was in wrappers instantiation. Initialized concrete types were incorrect. I've provided method for wrappers witch returns set of possible types in resolving. Now all of set's sizes equals 1.
Fixes #957
Type of Change
How Has This Been Tested?
Automated Testing
org.utbot.examples.casts.InstanceOfExampleTest
Manual Scenario
Described in issue #957
Checklist: