fix: #3786 fix issue when triggering an action that does not exist #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
suggested changes
Aug 21, 2018
lib/God/ActionMethods.js
Outdated
| @@ -801,6 +801,22 @@ module.exports = function(God) { | |||
|
|
|||
| var proc_env = God.clusters_db[id].pm2_env; | |||
|
|
|||
| var action_exist = false; | |||
| proc_env.axm_actions.forEach(function(action) { | |||
There was a problem hiding this comment.
Could be refactored to a simpler code :
const isActionAvailable = proc_env.axm_actions.find(action => action.action_name === cmd.msg) !== undefinedThere is console.log call also
vmarchaud
approved these changes
Aug 21, 2018
inerc
pushed a commit
to inerc/pm2
that referenced
this pull request
Feb 11, 2020
fix: Unitech#3786 fix issue when triggering an action that does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If action doesn't exist we should display an error, even if we trigger action by application's name.