feat: Switch to official AWS docker images by default #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2022
pgrzesik
force-pushed
the
change-default-images-to-official-aws
branch
from
f880bb8
to
babcb38
Compare
pgrzesik
force-pushed
the
change-default-images-to-official-aws
branch
from
babcb38
to
f89d05d
Compare
|
Should we also automatically use the matching platform image (e.g. This should be it: const defaultImage = `public.ecr.aws/sam/build-${this.serverless.service.provider.runtime}:latest-${this.serverless.service.provider.architecture}`;Currently to build provider:
name: aws
runtime: python3.9
architecture: arm64
custom:
pythonRequirements:
dockerizePip: true
dockerImage: public.ecr.aws/sam/build-${self:provider.runtime}:latest-${self:provider.architecture}With the suggested change to the PR, the |
|
Hey @nc-dirknilius, thanks for the proposition. I didn't think of that previously, but it sounds like a really good idea. I'll add that to the PR 👍 |
BREAKING CHANGE: Switches to official AWS docker images from previous `lambci` images that did not support Python 3.9
pgrzesik
force-pushed
the
change-default-images-to-official-aws
branch
from
f89d05d
to
654e0f1
Compare
badouralix
added a commit
to badouralix/rclone-lambda-sync
that referenced
this pull request
Oct 25, 2022
Overriding the default docker image for serverless is not needed as of serverless/serverless-python-requirements#724
whisller
added a commit
to epsylabs/serverless-builder
that referenced
this pull request
Jan 5, 2023
…`6.0.0` With version `6.0.0` of `serverless-python-requirements` they switched to use official AWS docker images. More info can be found in serverless/serverless-python-requirements#724 So we don’t need `lambci/lambda` anymore. With this change everyone who is using `serverless-python-requirements` plugin and will update `serverless-builder`, would have to upgrade `serverless-python-requirements` itself. I was considering two less breaking change approach like: 1. Introduce new plugin class ``` class PythonRequirements600 { } ``` 2. Modification of `PythonRequirements.__init__` and add `version` parameter But to be honest I don’t think it’s worth to maintain this backward compatibility.
whisller
added a commit
to epsylabs/serverless-builder
that referenced
this pull request
Jan 5, 2023
…`6.0.0` With version `6.0.0` of `serverless-python-requirements` they switched to use official AWS docker images. More info can be found in serverless/serverless-python-requirements#724 So we don’t need `lambci/lambda` anymore. With this change everyone who is using `serverless-python-requirements` plugin and will update `serverless-builder`, would have to upgrade `serverless-python-requirements` itself. I was considering two less breaking change approach like: 1. Introduce new plugin class ``` class PythonRequirements600 { } ``` 2. Modification of `PythonRequirements.__init__` and add `version` parameter But to be honest I don’t think it’s worth to maintain this backward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Switches to official AWS docker images from previous
lambciimages that did not support Python 3.9Switch to official images as defaults for packaging with Docker. Please note that it's a breaking change and will be released as a part of next major version of the plugin.
Closes: #647