[serverless-python-requirements] Make plugin compatible with version 6.0.0
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`6.0.0` With version `6.0.0` of `serverless-python-requirements` they switched to use official AWS docker images. More info can be found in serverless/serverless-python-requirements#724 So we don’t need `lambci/lambda` anymore. With this change everyone who is using `serverless-python-requirements` plugin and will update `serverless-builder`, would have to upgrade `serverless-python-requirements` itself. I was considering two less breaking change approach like: 1. Introduce new plugin class ``` class PythonRequirements600 { } ``` 2. Modification of `PythonRequirements.__init__` and add `version` parameter But to be honest I don’t think it’s worth to maintain this backward compatibility.
matepager
approved these changes
Jan 6, 2023
|
+1 for moving ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With version
6.0.0ofserverless-python-requirementsthey switched to use official AWS docker images. More info can be found in serverless/serverless-python-requirements#724So we don’t need
lambci/lambdaanymore.With this change everyone who is using
serverless-python-requirementsplugin and will updateserverless-builder, would have to upgradeserverless-python-requirementsitself.I was considering two less breaking change approach like:
PythonRequirements.__init__and addversionparameterBut to be honest I don’t think it’s worth to maintain this backward compatibility.